flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2354] Add job graph and checkpoint reco...
Date Fri, 02 Oct 2015 14:54:14 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SuccessfulCheckpoint.java
    @@ -19,29 +19,28 @@
     package org.apache.flink.runtime.checkpoint;
     import org.apache.flink.api.common.JobID;
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
    +import java.io.Serializable;
    +import java.util.ArrayList;
     import java.util.List;
      * A successful checkpoint describes a checkpoint after all required tasks acknowledged
it (with their state)
      * and that is considered completed.
    -public class SuccessfulCheckpoint {
    -	private static final Logger LOG = LoggerFactory.getLogger(SuccessfulCheckpoint.class);
    +public class SuccessfulCheckpoint implements Serializable {
    +	private static final long serialVersionUID = -8360248179615702014L;
     	private final JobID job;
     	private final long checkpointID;
     	private final long timestamp;
    -	private final List<StateForTask> states;
    +	private final ArrayList<StateForTask> states;
    --- End diff --
    Why changing it to `ArrayList`?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message