Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tillrohrmann <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
Message-ID: <git-pr-1141-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2690] [api-breaking] [scala api]
 [java ...
Content-Type: text/plain
Date: Thu, 17 Sep 2015 14:15:06 +0000 (UTC)

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1141

    [FLINK-2690] [api-breaking] [scala api] [java api] Allows CsvInputFormat to use derived Pojos

    This PR adds support for the `CsvInputFormat` to use derived Pojos. In order to also find pojo fields defined in a parent class, one has to traverse the type hierarchy. This is done by the function `findAllFields`.
    
    While working on the `CsvInputFormat`, I noticed that the `ScalaCsvInputFormat` shared almost all code with the `CsvInputFormat`. In order to reduce duplicated code, both input formats now extend the `CommonCsvInputFormat` which contains the shared code.
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixCsvInputFormatPojo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1141
    
----
commit bf2e2c40f340ccfe31256744380345287c9e6f9e
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2015-09-17T13:28:25Z

    [FLINK-2690] [api-breaking] [scala api] [java api] Adds functionality to the CsvInputFormat to find fields defined in a super class of a Pojo. Refactors CsvInputFormat to share code between this format and ScalaCsvInputFormat.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---