Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3137518672 for ; Tue, 22 Sep 2015 22:25:11 +0000 (UTC) Received: (qmail 1195 invoked by uid 500); 22 Sep 2015 22:25:04 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 1152 invoked by uid 500); 22 Sep 2015 22:25:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 1076 invoked by uid 99); 22 Sep 2015 22:25:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2015 22:25:04 +0000 Date: Tue, 22 Sep 2015 22:25:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2723) CopyableValue method to copy into new instance MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903564#comment-14903564 ] ASF GitHub Bot commented on FLINK-2723: --------------------------------------- Github user uce commented on the pull request: https://github.com/apache/flink/pull/1169#issuecomment-142439086 Nice. And good explanation for the change. +1 to merge. Optionally: While at it, it might be helpful to add two short Javadoc comments to `copy` and `copyTo`. > CopyableValue method to copy into new instance > ---------------------------------------------- > > Key: FLINK-2723 > URL: https://issues.apache.org/jira/browse/FLINK-2723 > Project: Flink > Issue Type: New Feature > Components: Core > Affects Versions: master > Reporter: Greg Hogan > Assignee: Greg Hogan > Priority: Minor > > Provide a method for generic user-defined functions to clone a {{CopyableValue}}. A common use case is a {{GroupReduceFunction}} that needs to store multiple objects. With object reuse we need to make a deep copy and with type erasure we cannot call new. -- This message was sent by Atlassian JIRA (v6.3.4#6332)