Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 115EE10C03 for ; Tue, 8 Sep 2015 08:50:46 +0000 (UTC) Received: (qmail 14986 invoked by uid 500); 8 Sep 2015 08:50:46 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 14957 invoked by uid 500); 8 Sep 2015 08:50:45 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 14947 invoked by uid 99); 8 Sep 2015 08:50:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2015 08:50:45 +0000 Date: Tue, 8 Sep 2015 08:50:45 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2633) OptionTypeInfo does not have proper equals and hashCode method MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734432#comment-14734432 ] ASF GitHub Bot commented on FLINK-2633: --------------------------------------- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1104#issuecomment-138483121 How about we override `hashCode()`, `equals()`, and `toString()` in the `TypeInformation` base class as `abstract`? That forces subclasses to override these methods. > OptionTypeInfo does not have proper equals and hashCode method > -------------------------------------------------------------- > > Key: FLINK-2633 > URL: https://issues.apache.org/jira/browse/FLINK-2633 > Project: Flink > Issue Type: Bug > Reporter: Till Rohrmann > Assignee: Till Rohrmann > > The {{OptionTypeInfo}} does not have a proper {{equals}} and {{hashCode}} definition. As a consequence, types which contain an option type won't be detected to be equal even though the element type of the option is identical. > This can cause problems when you try to union two data sets of type {{DataSet[Option[Int]]}}, for example. -- This message was sent by Atlassian JIRA (v6.3.4#6332)