Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5335E1094F for ; Mon, 7 Sep 2015 08:19:46 +0000 (UTC) Received: (qmail 43068 invoked by uid 500); 7 Sep 2015 08:19:46 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 43015 invoked by uid 500); 7 Sep 2015 08:19:46 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 43003 invoked by uid 99); 7 Sep 2015 08:19:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Sep 2015 08:19:46 +0000 Date: Mon, 7 Sep 2015 08:19:46 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733376#comment-14733376 ] ASF GitHub Bot commented on FLINK-2017: --------------------------------------- Github user uce commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-138229357 Thanks for the PR! I am sure that the mentioned test failure is unrelated to your changes. If you like, you can create a new issue with the label test-instability for the failing test. > Add predefined required parameters to ParameterTool > --------------------------------------------------- > > Key: FLINK-2017 > URL: https://issues.apache.org/jira/browse/FLINK-2017 > Project: Flink > Issue Type: Improvement > Affects Versions: 0.9 > Reporter: Robert Metzger > Labels: starter > > In FLINK-1525 we've added the {{ParameterTool}}. > During the PR review, there was a request for required parameters. > This issue is about implementing a facility to define required parameters. The tool should also be able to print a help menu with a list of all parameters. > This test case shows my initial ideas how to design the API > {code} > @Test > public void requiredParameters() { > RequiredParameters required = new RequiredParameters(); > Option input = required.add("input").alt("i").help("Path to input file or directory"); // parameter with long and short variant > required.add("output"); // parameter only with long variant > Option parallelism = required.add("parallelism").alt("p").type(Integer.class); // parameter with type > Option spOption = required.add("sourceParallelism").alt("sp").defaultValue(12).help("Number specifying the number of parallel data source instances"); // parameter with default value, specifying the type. > Option executionType = required.add("executionType").alt("et").defaultValue("pipelined").choices("pipelined", "batch"); > ParameterUtil parameter = ParameterUtil.fromArgs(new String[]{"-i", "someinput", "--output", "someout", "-p", "15"}); > required.check(parameter); > required.printHelp(); > required.checkAndPopulate(parameter); > String inputString = input.get(); > int par = parallelism.getInteger(); > String output = parameter.get("output"); > int sourcePar = parameter.getInteger(spOption.getName()); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)