Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1137-flink@git.apache.org>
In-Reply-To: <git-pr-1137-flink@git.apache.org>
Subject: [GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak
 resource ...
Content-Type: text/plain
Message-Id: <20150916195124.9457FE00AB@git1-us-west.apache.org>
Date: Wed, 16 Sep 2015 19:51:24 +0000 (UTC)

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1137#discussion_r39676482
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java ---
    @@ -46,13 +46,16 @@ public void testWithURLClassLoader() {
     			jarFileCreator.createJarFile();
     			
     			// validate that the JAR is correct and the test setup is not broken
    +			JarFile jarFile = null;
     			try {
    -				new JarFile(validJar.getAbsolutePath());
    +				jarFile = new JarFile(validJar.getAbsolutePath());
     			}
     			catch (Exception e) {
     				e.printStackTrace();
     				fail("test setup broken: cannot create a valid jar file");
    -			}
    +			} finally {
    +                                if (jarFile != null) jarFile.close();
    --- End diff --
    
    We use tabs for indention in Java code. Can you fix this and the next line?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---