Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: mjsax <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-750-flink@git.apache.org>
In-Reply-To: <git-pr-750-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to
 cleanly shut...
Content-Type: text/plain
Message-Id: <20150901190729.A6557E0418@git1-us-west.apache.org>
Date: Tue,  1 Sep 2015 19:07:29 +0000 (UTC)

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38458556
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala ---
    @@ -411,6 +411,23 @@ class TaskManager(
                 log.debug(s"Cannot find task to fail for execution ${executionID})")
               }
     
    +        // stops a task
    +        case StopTask(executionID) =>
    +          val task = runningTasks.get(executionID)
    +          if (task != null) {
    +            try {
    +              task.stopExecution()
    --- End diff --
    
    @aljoscha do you have any input on this? I am not sure what the next step should be here? @tillrohrmann do you have any other comments on the whole PR? I would like to finish this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---