Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: StephanEwen <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1030-flink@git.apache.org>
In-Reply-To: <git-pr-1030-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect
 for so...
Content-Type: text/plain
Message-Id: <20150901112756.055F8DFB8A@git1-us-west.apache.org>
Date: Tue,  1 Sep 2015 11:27:55 +0000 (UTC)

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1030#discussion_r38408757
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java ---
    @@ -73,13 +90,56 @@ public void intializeConnection() {
     	 *			The incoming data
     	 */
     	@Override
    -	public void invoke(IN value) {
    +	public void invoke(IN value) throws Exception {
     		byte[] msg = schema.serialize(value);
     		try {
     			dataOutputStream.write(msg);
     		} catch (IOException e) {
    -			throw new RuntimeException("Cannot send message " + value.toString() +
    -					" to socket server at " + hostName + ":" + port, e);
    +			LOG.error("Cannot send message " + value.toString() +
    +					" to socket server at " + hostName + ":" + port + ". Caused by " + e.toString() +
    +					". Trying to reconnect.");
    +			retries = 0;
    +			boolean success = false;
    +			while ((retries < maxRetry || retryForever) && !success && isRunning){
    +				try {
    +
    +					if (dataOutputStream != null) {
    +						dataOutputStream.close();
    +					}
    +
    +					if (client != null && !client.isClosed()) {
    +						client.close();
    +					}
    +
    +					retries++;
    +
    +					client = new Socket(hostName, port);
    +					dataOutputStream = new DataOutputStream(client.getOutputStream());
    +					dataOutputStream.write(msg);
    +					success = true;
    +
    +				} catch(IOException ee) {
    +					LOG.error("Reconnect to socket server and send message failed. Caused by " +
    +							ee.toString() + ". Retry time(s):" + retries);
    +
    +					if (lock == null) {
    +						lock = new Object();
    +					}
    +
    +					try {
    +						synchronized (lock) {
    +							lock.wait(CONNECTION_RETRY_SLEEP);
    +						}
    +					} catch(InterruptedException eee) {
    +						LOG.error(eee.toString());
    --- End diff --
    
    I think there is no need to log this. Interrupting the thread usually means that it has been shut down.
    
    If you want to log exceptions, log them via ("message", exeption), here `LOG.error("Reconnect delay interrupted", e);`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---