flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsaputra <...@git.apache.org>
Subject [GitHub] flink pull request: [CLEANUP] Cleanup code as part of theme to be ...
Date Mon, 28 Sep 2015 20:05:38 GMT
GitHub user hsaputra opened a pull request:

    https://github.com/apache/flink/pull/1189

    [CLEANUP] Cleanup code as part of theme to be more consistent

    As part of the theme to help make the code more consistent, add cleanup to Utils classes:
    -) Add final class modifier to the XXXUtils and XXXUtil classes to make sure can not be
extended.
    -) Add missing Javadoc header classs to some public classes.
    -) Add private constructor to Utils classes to avoid instantiation.
    -) Remove unused test/java/org/apache/flink/test/recordJobs/util/ConfigUtils.java class

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/flink add_missing_javadocs_class

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1189
    
----
commit eeb10e6eb43441c445c920c5af2dfe3f55c8ba74
Author: hsaputra <hsaputra@apache.org>
Date:   2015-09-28T19:56:16Z

    Cleanup code as part of theme to be more consistent:
    -) Add final class modifier to the XXXUtils and XXXUtil classes to make sure could not
be extended.
    -) Add missing Javadoc header classs to some public classes.
    -) Add private constructor to Utils classes to avoid instantiation.
    -) Remove unused test/java/org/apache/flink/test/recordJobs/util/ConfigUtils.java class

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message