flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2775) [CLEANUP] Cleanup code as part of theme to be more consistent on Utils classes
Date Tue, 29 Sep 2015 10:03:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934945#comment-14934945

ASF GitHub Bot commented on FLINK-2775:

Github user StephanEwen commented on the pull request:

    Looks good. @zentol's comments are nice-to-address issues.
    +1 to merge with addressing the comments

> [CLEANUP] Cleanup code as part of theme to be more consistent on Utils classes
> ------------------------------------------------------------------------------
>                 Key: FLINK-2775
>                 URL: https://issues.apache.org/jira/browse/FLINK-2775
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>            Priority: Minor
> As part of the theme to help make the code more consistent, add cleanup to Utils classes:
> -) Add final class modifier to the XXXUtils and XXXUtil classes to make sure can not
be extended.
> -) Add missing Javadoc header classs to some public classes.
> -) Add private constructor to Utils classes to avoid instantiation.
> -) Remove unused test/java/org/apache/flink/test/recordJobs/util/ConfigUtils.java class

This message was sent by Atlassian JIRA

View raw message