flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2698) Add trailing newline to flink-conf.yaml
Date Thu, 17 Sep 2015 20:49:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804477#comment-14804477
] 

ASF GitHub Bot commented on FLINK-2698:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/1142

    [FLINK-2698] Add trailing newline to flink-conf.yaml

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 2698_add_trailing_newline_to_conf

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1142
    
----
commit 963cac12a0979ec044c134bab2da6d440fd3c362
Author: Greg Hogan <code@greghogan.com>
Date:   2015-09-17T18:54:48Z

    [FLINK-2698] Add trailing newline to flink-conf.yaml

----


> Add trailing newline to flink-conf.yaml
> ---------------------------------------
>
>                 Key: FLINK-2698
>                 URL: https://issues.apache.org/jira/browse/FLINK-2698
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: master
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The distributed flink-conf.yaml does not contain a trailing newline. This interferes
with [bdutil|https://github.com/GoogleCloudPlatform/bdutil/blob/master/extensions/flink/install_flink.sh#L64]
which appends extra/override configuration parameters with a heredoc.
> There are many other files without trailing newlines, but this looks to be the only detrimental
effect.
> {code}
> for i in $(find * -type f) ; do if diff /dev/null "$i" | tail -1 | grep '^\\ No newline'
> /dev/null; then  echo $i; fi; done
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message