flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FLINK-2649) Potential resource leak in JarHelper#unjar()
Date Wed, 16 Sep 2015 01:53:45 GMT

     [ https://issues.apache.org/jira/browse/FLINK-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated FLINK-2649:
--------------------------
    Description: 
{code}
    dest = new BufferedOutputStream(fos, BUFFER_SIZE);
    while ((count = jis.read(data, 0, BUFFER_SIZE)) != -1) {
    dest.write(data, 0, count);
    }
    dest.flush();
    dest.close();
{code}

The close() of dest should be enclosed in finally block.

  was:
{code}
    dest = new BufferedOutputStream(fos, BUFFER_SIZE);
    while ((count = jis.read(data, 0, BUFFER_SIZE)) != -1) {
    dest.write(data, 0, count);
    }
    dest.flush();
    dest.close();
{code}
The close() of dest should be enclosed in finally block.


> Potential resource leak in JarHelper#unjar()
> --------------------------------------------
>
>                 Key: FLINK-2649
>                 URL: https://issues.apache.org/jira/browse/FLINK-2649
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> {code}
>     dest = new BufferedOutputStream(fos, BUFFER_SIZE);
>     while ((count = jis.read(data, 0, BUFFER_SIZE)) != -1) {
>     dest.write(data, 0, count);
>     }
>     dest.flush();
>     dest.close();
> {code}
> The close() of dest should be enclosed in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message