flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation
Date Wed, 16 Sep 2015 14:19:46 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14769004#comment-14769004
] 

ASF GitHub Bot commented on FLINK-2637:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1134#discussion_r39634911
  
    --- Diff: flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RenamingProxyTypeInfo.scala
---
    @@ -31,7 +32,8 @@ import org.apache.flink.api.common.typeutils.{CompositeType, TypeComparator,
Typ
      */
     class RenamingProxyTypeInfo[T](
         tpe: CompositeType[T],
    --- End diff --
    
    Yes, will the `vals`.


> Add abstract equals, hashCode and toString methods to TypeInformation
> ---------------------------------------------------------------------
>
>                 Key: FLINK-2637
>                 URL: https://issues.apache.org/jira/browse/FLINK-2637
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.9, 0.10
>            Reporter: Fabian Hueske
>            Assignee: Till Rohrmann
>              Labels: starter
>             Fix For: 0.10
>
>
> Flink expects that implementations of {{TypeInformation}} have valid implementations
of {{hashCode}} and {{equals}}. However, the API does not enforce to implement these methods.
Hence, this is a common origin for bugs such as for example FLINK-2633.
> This can be avoided by adding abstract {{hashCode}} and {{equals}} methods to TypeInformation.
An abstract {{toString}} method could also be added.
> This change will brake the API and require to fix a couple of broken {{TypeInformation}}
implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message