flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation
Date Thu, 17 Sep 2015 18:01:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803309#comment-14803309
] 

ASF GitHub Bot commented on FLINK-2637:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1134#issuecomment-141167625
  
    Hey @rxin, I'm really sorry that this happened. Max told me that he stopped the application
on AppEngine as soon as he learned that the tool is not working as expected.
    As far as I can see the JIRA activity of Max's user account, the tool stopped changing
Spark issues 3 hours ago.
    Please let me know if more Spark JIRAs are affected.
    I'll ask @mxm to remove the automated comments again and change the links back to their
old value.


> Add abstract equals, hashCode and toString methods to TypeInformation
> ---------------------------------------------------------------------
>
>                 Key: FLINK-2637
>                 URL: https://issues.apache.org/jira/browse/FLINK-2637
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.9, 0.10
>            Reporter: Fabian Hueske
>            Assignee: Till Rohrmann
>              Labels: starter
>             Fix For: 0.10
>
>
> Flink expects that implementations of {{TypeInformation}} have valid implementations
of {{hashCode}} and {{equals}}. However, the API does not enforce to implement these methods.
Hence, this is a common origin for bugs such as for example FLINK-2633.
> This can be avoided by adding abstract {{hashCode}} and {{equals}} methods to TypeInformation.
An abstract {{toString}} method could also be added.
> This change will brake the API and require to fix a couple of broken {{TypeInformation}}
implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message