flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation
Date Thu, 17 Sep 2015 17:45:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803289#comment-14803289

ASF GitHub Bot commented on FLINK-2637:

Github user rxin commented on the pull request:

    I understand you took the bot from Spark, but can you change the JIRA link? It is spamming
the Spark JIRA right now.

> Add abstract equals, hashCode and toString methods to TypeInformation
> ---------------------------------------------------------------------
>                 Key: FLINK-2637
>                 URL: https://issues.apache.org/jira/browse/FLINK-2637
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.9, 0.10
>            Reporter: Fabian Hueske
>            Assignee: Till Rohrmann
>              Labels: starter
>             Fix For: 0.10
> Flink expects that implementations of {{TypeInformation}} have valid implementations
of {{hashCode}} and {{equals}}. However, the API does not enforce to implement these methods.
Hence, this is a common origin for bugs such as for example FLINK-2633.
> This can be avoided by adding abstract {{hashCode}} and {{equals}} methods to TypeInformation.
An abstract {{toString}} method could also be added.
> This change will brake the API and require to fix a couple of broken {{TypeInformation}}

This message was sent by Atlassian JIRA

View raw message