flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2633) OptionTypeInfo does not have proper equals and hashCode method
Date Tue, 08 Sep 2015 08:50:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734432#comment-14734432

ASF GitHub Bot commented on FLINK-2633:

Github user StephanEwen commented on the pull request:

    How about we override `hashCode()`, `equals()`, and `toString()` in the `TypeInformation`
base class as `abstract`? That forces subclasses to override these methods.

> OptionTypeInfo does not have proper equals and hashCode method
> --------------------------------------------------------------
>                 Key: FLINK-2633
>                 URL: https://issues.apache.org/jira/browse/FLINK-2633
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
> The {{OptionTypeInfo}} does not have a proper {{equals}} and {{hashCode}} definition.
As a consequence, types which contain an option type won't be detected to be equal even though
the element type of the option is identical. 
> This can cause problems when you try to union two data sets of type {{DataSet[Option[Int]]}},
for example.

This message was sent by Atlassian JIRA

View raw message