flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2605) Unclosed RandomAccessFile may leak resource in StaticFileServerHandler
Date Fri, 04 Sep 2015 21:26:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731459#comment-14731459
] 

ASF GitHub Bot commented on FLINK-2605:
---------------------------------------

Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/1089#issuecomment-137857005
  
    +1
    
    LGTM


> Unclosed RandomAccessFile may leak resource in StaticFileServerHandler
> ----------------------------------------------------------------------
>
>                 Key: FLINK-2605
>                 URL: https://issues.apache.org/jira/browse/FLINK-2605
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>         Attachments: flink-2605-v1.txt
>
>
> {code}
>     final RandomAccessFile raf;
>     try {
>       raf = new RandomAccessFile(file, "r");
>     }
>     catch (FileNotFoundException e) {
>       sendError(ctx, NOT_FOUND);
>       return;
>     }
> {code}
> If there is exception after raf is created but before method returns, raf would be left
unclosed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message