flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility
Date Tue, 08 Sep 2015 11:18:47 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734648#comment-14734648
] 

ASF GitHub Bot commented on FLINK-2525:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1046#discussion_r38914053
  
    --- Diff: docs/apis/storm_compatibility.md ---
    @@ -201,6 +201,26 @@ DataStream<BoltOutputType> s2 = splitStream.select("s2").transform(/*
use Bolt f
     
     See [SpoutSplitExample.java](https://github.com/apache/flink/tree/master/flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/split/SpoutSplitExample.java)
for a full example.
     
    +## Configure for embedded Spouts/Bolts
    +Embedder spouts/bolts can be configure with user defined parameters. User defined parameters
is a config `Map` and be called by `Spout.open(...)` and `Bolt.prepare()`
    +as first parameter. Configuration can be used in storm topologies mode or flink mode.
    +
    + 1.Storm topologies mode example
    --- End diff --
    
    I don't think we need example code for embedded mode. (See "multiple output streams":
 If a whole topology is executed using FlinkTopologyBuilder etc., there is no special attention
required – it works as in regular Storm. ). A simple sentence in the paragraph should be
sufficient.


> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and `Bolt.prepare()`,
respectively. Both methods have a config `Map` as first parameter. This map is currently not
populated. Thus, Spouts and Bolts cannot be configure with user defined parameters. In order
to support this feature, spout and bolt wrapper classes need to be extended to create a proper
`Map` object. Furthermore, the clients need to be extended to take a `Map`, translate it into
a Flink `Configuration` that is forwarded to the wrappers for proper initialization of the
map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message