flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility
Date Mon, 07 Sep 2015 14:59:46 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733812#comment-14733812

ASF GitHub Bot commented on FLINK-2525:

Github user mjsax commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/StormFileSpout.java
    @@ -45,9 +49,16 @@ public StormFileSpout(final String path) {
     	public void open(final Map conf, final TopologyContext context, final SpoutOutputCollector
collector) {
     		super.open(conf, context, collector);
     		try {
    +			/*  If config is given, it should override constructor path  */
    +			if (conf != null && conf.containsKey("textpath")) {
    +				this.path = (String)conf.get("textpath");
    --- End diff --
    `conf != null` can be removed.

> Add configuration support in Storm-compatibility
> ------------------------------------------------
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: fangfengbin
>            Assignee: fangfengbin
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and `Bolt.prepare()`,
respectively. Both methods have a config `Map` as first parameter. This map is currently not
populated. Thus, Spouts and Bolts cannot be configure with user defined parameters. In order
to support this feature, spout and bolt wrapper classes need to be extended to create a proper
`Map` object. Furthermore, the clients need to be extended to take a `Map`, translate it into
a Flink `Configuration` that is forwarded to the wrappers for proper initialization of the

This message was sent by Atlassian JIRA

View raw message