flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2561] Adds missing Gelly scala methods ...
Date Mon, 28 Sep 2015 11:10:04 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1183#issuecomment-143714240
  
    Looks good to me!
    
    One style comment: I think that `collect()` should be written with parenthesis. In Scala,
you use parenthesis if the methods are not purely accessing properties. The `collect()` function
as effects.
    
    Minor comment about the `serialVersionUID` in Scala inline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message