flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chiwanpark <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2751] [Documentation] Add quickstart me...
Date Thu, 24 Sep 2015 11:00:04 GMT
Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1176#issuecomment-142895387
  
    Hi @rerngvit, I have tested your pull request.
    
    Because `setup_quickstart.html` contains "setup" keyword in url, there are two active
menus (Quickstart, Setup) when we open Quickstart: Setup page. I found a solution like following:
    
    ```html
    <li class="dropdown{% if page.url contains '/quickstart/' %} active{% endif %}">
    ```
    
    The solution must be applied not only quickstart but also other dropdown menus such as
setup, programming guide, ..., etc..
    
    BTW, there is a typo line 68 of `navbar.html`. A tag must be closed. I know this is not
related your changes but fixing it would be better.
    
    After addressing this, we can merge this pull request. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message