flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Tue, 22 Sep 2015 15:54:20 GMT
Github user rmetzger commented on the pull request:

    I think the implementation of `stopExecution()` is fine. You are executing the call in
a separate thread and you are logging exceptions. A blocking stop() method implemented by
a user would not block the actor.
    I would catch `Throwable` instead of `RuntimeException`, just to ensure that really no
exception is thrown out of the thread.
    This PR is touching very critical components of Flink. I would really appreciate a review
by @tillrohrmann and @StephanEwen.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message