flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HuangWHWHW <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...
Date Mon, 14 Sep 2015 00:55:12 GMT
Github user HuangWHWHW commented on the pull request:

    https://github.com/apache/flink/pull/1098#issuecomment-139933029
  
    `I still cannot understand what is the purpose of adding javaSet to the Table API. We
can get the DataSet by using toDataSet method.`
    
    @fhueske 
    @chiwanpark 
    Hi, don't think too complicated.
    This is just about the compile error for the Table API tests since I added the `def writeAsText(
filePath: String, writeMode: FileSystem.WriteMode = null): DataSink[T]` method in `DataStream.scala`.
    For easy understanding, you can also take a experiment that add the method and you will
get some errors in these Table API tests.
    To add the `javaSet` just a way that I can pass these tests and I'm not sure this change
is suitable.
    If not, how can I do?
    Refactor Table API in a new JIRA or here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message