flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2634] [gelly] Added a vertex-centric Tr...
Date Fri, 11 Sep 2015 13:53:34 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1105#issuecomment-139553246
  
    I did not go through the code in detail. Maybe I am missing something, but isn't this
algorithm doing pretty much the same thing as the example we have already for the DataSet
API examples (Java + Scala). In the existing examples (EnumTrianglesOpt) 3 reduce and 1 join
to enumerate all triangles. We would need one more reduce to compute the number of triangles
which makes 4 reduce and 1 join.
    In your code you are using 5 reduce and 2 joins if I counted correctly. 
    
    Are those two algorithms doing different things or could you basically port the existing
code to Gelly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message