flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2654][flink-java] Add JavaDoc to Parame...
Date Thu, 10 Sep 2015 15:24:20 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1116#discussion_r39173067
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java
---
    @@ -136,15 +157,35 @@ public static ParameterTool fromPropertiesFile(String path) throws
IOException {
     		return fromMap((Map)props);
     	}
     
    +    /**
    +     * Returns {@link ParameterTool} for the given map
    +	 *
    +     * @param map A map of arguments. Both Key and Value have to be Strings
    +     * @return A {@link ParameterTool}
    +     */
     	public static ParameterTool fromMap(Map<String, String> map) {
     		Preconditions.checkNotNull(map, "Unable to initialize from empty map");
     		return new ParameterTool(map);
     	}
     
    +    /**
    +     * Returns {@link ParameterTool} from the system properties
    --- End diff --
    
    Maybe it would make sense to add that people can pass system properties to the jvm using
`-Dkey=value`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message