flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tammymendt <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...
Date Wed, 09 Sep 2015 11:35:01 GMT
Github user tammymendt commented on the pull request:

    The test I wrote checks if the final accumulator result is the one that is expected. If
I understand correctly, now accumulator values are sent periodically before a task finishes.
Do I need to write an additional test to make sure that accumulator results before task end
are also as expected? If not I would say it is ok to merge. Have you written extra tests for
other accumulators like IntCounter?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message