flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...
Date Wed, 09 Sep 2015 09:00:52 GMT
Github user StephanEwen commented on the pull request:

    I think this looks good, except for the comment with the final variable for the lock.
    One more comment: When concatenating strings, avoid constructs like `" value=" + value.toString()`.
Rather do `"value=" + value`. That is safe against null pointers.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message