flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsaputra <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1320] [core] Add an off-heap variant of...
Date Tue, 08 Sep 2015 19:05:35 GMT
Github user hsaputra commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/core/memory/MemorySegmentFactory.java
    @@ -0,0 +1,135 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.core.memory;
    +import java.nio.ByteBuffer;
    + * A factory for memory segments. The purpose of this factory is to make sure that all
memory segments
    + * for heap data are of the same type. That way, the runtime does not mix the various
    + * of the {@link org.apache.flink.core.memory.MemorySegment}. Not mixing them has shown
to be beneficial
    + * to method specialization by the JIT and to overall performance.
    + * <p>
    + * Note that this factory auto-initialized to use {@link org.apache.flink.core.memory.HeapMemorySegment},
    + * if a request to create a segment comes before the initialization.
    + */
    +public class MemorySegmentFactory {
    +	/** The factory to use */
    +	private static Factory factory;
    --- End diff --
    @StephanEwen since you already merge this PR, could file JIRA to follow up on this one?
Want to make sure we got this right.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message