flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2631] [streaming] Fixes the StreamFold ...
Date Tue, 08 Sep 2015 09:00:19 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1101#discussion_r38903676
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/operators/OutputTypeConfigurable.java
---
    @@ -0,0 +1,42 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.api.operators;
    +
    +import org.apache.flink.api.common.ExecutionConfig;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +
    +/**
    + * Stream operators can implement this interface if they need access to the output type
information
    + * at {@link org.apache.flink.streaming.api.graph.StreamGraph} generation. This can be
useful for
    + * cases where the output type is specified by the returns method and, thus, after the
stream
    + * operator has been created.
    + */
    +public interface OutputTypeConfigurable {
    +
    +	/**
    +	 * Is called by the {@link org.apache.flink.streaming.api.graph.StreamGraph#addOperator(Integer,
StreamOperator, TypeInformation, TypeInformation, String)}
    +	 * method when the {@link org.apache.flink.streaming.api.graph.StreamGraph} is generated.
The
    +	 * method is called with the output {@link TypeInformation} which is also used for the
    +	 * {@link org.apache.flink.streaming.runtime.tasks.StreamTask} output serializer.
    +	 *
    +	 * @param outTypeInfo Output type information of the {@link org.apache.flink.streaming.runtime.tasks.StreamTask}
    +	 * @param executionConfig Execution configuration
    +	 */
    +	void setOutputType(TypeInformation<?> outTypeInfo, ExecutionConfig executionConfig);
    --- End diff --
    
    Why don't we type the interface, so that we don't need casts in `setOutputType` implementations
at the operator?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message