flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...
Date Fri, 04 Sep 2015 14:17:23 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1046#issuecomment-137748262
  
    Concerning the changes at the core classes:
      - The storm config key is an application specific key and not part of the system configuration,
therefore it should be defined as part of the application code.
      - When returning the JobManager configuration, this should return an unmodifiable configuration,
so the internal config cannot be altered.
      - Do you need access to the inner config hashmap? How about storing the storm specific
properties in a key like this: `InstantiationUtil.writeObjectToConfig(stormProps, config,
"STORM_CONF");`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message