flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...
Date Thu, 03 Sep 2015 08:02:05 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1073#discussion_r38621376
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
    @@ -73,21 +51,22 @@ public void testPrintSinkStdOut(){
     		try {
     			printSink.open(new Configuration());
     		} catch (Exception e) {
    -			e.printStackTrace();
    +			Assert.fail();
     		}
     		printSink.setTargetToStandardOut();
     		printSink.invoke("hello world!");
     
     		assertEquals("Print to System.out", printSink.toString());
    -		assertEquals("hello world!", stream.result);
    +		assertEquals("hello world!\r\n", baos.toString());
    --- End diff --
    
    This will work on Windows (`\r\n` for newline) but not on Unix systems (`\n` for newline).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message