flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HuangWHWHW <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...
Date Tue, 01 Sep 2015 12:24:11 GMT
Github user HuangWHWHW commented on the pull request:

    https://github.com/apache/flink/pull/1073#issuecomment-136694516
  
    @StephanEwen 
    Hi, I take changes for all of your comments but this following:
    
    "The mock print stream overwrites only one println() function, which makes it susceptible
to changes in the sink. It is better to use a regular PrintStream that prints to a StringWriter
to collect all contents."
    
    I have no ideas to assert the print is correct.
    So can you tell me in detail?
    Thank you very much!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message