flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...
Date Tue, 01 Sep 2015 11:24:54 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1030#discussion_r38408542
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java
---
    @@ -73,13 +90,56 @@ public void intializeConnection() {
     	 *			The incoming data
     	 */
     	@Override
    -	public void invoke(IN value) {
    +	public void invoke(IN value) throws Exception {
     		byte[] msg = schema.serialize(value);
     		try {
     			dataOutputStream.write(msg);
     		} catch (IOException e) {
    -			throw new RuntimeException("Cannot send message " + value.toString() +
    -					" to socket server at " + hostName + ":" + port, e);
    +			LOG.error("Cannot send message " + value.toString() +
    --- End diff --
    
    You can log the exception simpler like this:
    ```
    LOG.error("Cannot send message " + value + " to socket server at " + hostName + ":" +
port + ". Trying to reconnect.", e);
    `ยด`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message