Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2E90817FA8 for ; Sun, 23 Aug 2015 14:35:46 +0000 (UTC) Received: (qmail 68812 invoked by uid 500); 23 Aug 2015 14:35:46 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 68771 invoked by uid 500); 23 Aug 2015 14:35:46 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 68538 invoked by uid 99); 23 Aug 2015 14:35:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Aug 2015 14:35:46 +0000 Date: Sun, 23 Aug 2015 14:35:45 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2563) Gelly's Graph Algorithm Interface is limited MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708391#comment-14708391 ] ASF GitHub Bot commented on FLINK-2563: --------------------------------------- GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1042 [FLINK-2563] [gelly] changed Graph's run() to return an arbitrary result type Added a type parameter to the 'GraphAlgorithm' interface to allow implementing library methods that return single values, Graphs of different types, etc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vasia/flink graphAlgorithm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1042.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1042 ---- commit ff7240b9fd1a899c938108604875ea16023e7a78 Author: vasia Date: 2015-08-23T11:06:15Z [FLINK-2563] [gelly] extended the run() method of GraphAlgorithm interface to return an arbitrary type ---- > Gelly's Graph Algorithm Interface is limited > -------------------------------------------- > > Key: FLINK-2563 > URL: https://issues.apache.org/jira/browse/FLINK-2563 > Project: Flink > Issue Type: Improvement > Components: Gelly > Affects Versions: 0.9, 0.10 > Reporter: Andra Lungu > Assignee: Vasia Kalavri > > Right now, Gelly's `GraphAlgorithm` interface only allows users/devs to return the same type of Graph. > public Graph run(Graph input) throws Exception; > In numerous cases, one needs to return a single value, or a modified graph. > Off the top of my head, say one would like to implement a Triangle Count library method. That takes as input a Graph and returns the total number of triangles. > https://github.com/andralungu/gelly-partitioning/blob/master/src/main/java/example/GSATriangleCount.java > With the current Gelly abstractions, something like this cannot be supported. Also if I initially had a Graph of Long, Long, NullValue and my algorithm changed the edge values to type Double, for instance, I would again have created an implementation which is not supported. -- This message was sent by Atlassian JIRA (v6.3.4#6332)