Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 24 Aug 2015 12:44:48 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12856331.1439607466000.145446.1440420288298@Atlassian.JIRA>
In-Reply-To: <JIRA.12856331.1439607466000@Atlassian.JIRA>
References: <JIRA.12856331.1439607466000@Atlassian.JIRA>
 <JIRA.12856331.1439607466629@arcas>
Subject: [jira] [Commented] (FLINK-2525) Add configuration support in
 Storm-compatibility
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709194#comment-14709194 ] 

ASF GitHub Bot commented on FLINK-2525:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1046#discussion_r37746515
  
    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java ---
    @@ -41,8 +43,49 @@ public void submitTopology(final String topologyName, final Map<?, ?> conf, fina
     
     	public void submitTopologyWithOpts(final String topologyName, final Map<?, ?> conf, final FlinkTopology topology,
     			final SubmitOptions submitOpts) throws Exception {
    -		ClusterUtil
    -				.startOnMiniCluster(topology.getStreamGraph().getJobGraph(topologyName), topology.getNumberOfTasks());
    +		JobGraph jobGraph = topology.getStreamGraph().getJobGraph(topologyName);
    +		Configuration jobConfiguration = jobGraph.getJobConfiguration();
    +
    +		/* storm conf type must be Map<String, Object> */
    +		Map<String, Object> stormConf = (Map<String, Object>)conf;
    --- End diff --
    
    The definition of `Config` in not important here. Storm uses raw map as parameter in `StormSubmitter.submitTopology(...)`, `Spout.open(...)`, and `Bolt.prepare(...)`. Thus, it would be possible to use a different type than `String` for key values.


> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: flink-contrib
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and `Bolt.prepare()`, respectively. Both methods have a config `Map` as first parameter. This map is currently not populated. Thus, Spouts and Bolts cannot be configure with user defined parameters. In order to support this feature, spout and bolt wrapper classes need to be extended to create a proper `Map` object. Furthermore, the clients need to be extended to take a `Map`, translate it into a Flink `Configuration` that is forwarded to the wrappers for proper initialization of the map.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)