Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: mjsax <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-750-flink@git.apache.org>
In-Reply-To: <git-pr-750-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to
 cleanly shut...
Content-Type: text/plain
Message-Id: <20150828121734.C08BDE053F@git1-us-west.apache.org>
Date: Fri, 28 Aug 2015 12:17:34 +0000 (UTC)

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38193714
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala ---
    @@ -411,6 +411,23 @@ class TaskManager(
                 log.debug(s"Cannot find task to fail for execution ${executionID})")
               }
     
    +        // stops a task
    +        case StopTask(executionID) =>
    +          val task = runningTasks.get(executionID)
    +          if (task != null) {
    +            try {
    +              task.stopExecution()
    +              sender ! new TaskOperationResult(executionID, true)
    +            } catch {
    +              case t: Throwable =>
    +                        sender ! new TaskOperationResult(executionID, false, t.getMessage())
    --- End diff --
    
    I thought I need to send back a `TaskOperationResult` (which does not take only `String` as parameter for an error message). And `stopExecution` might throw an `UnsupportedOperationException` (which should not happen, if code is correct). Please give some more advice (I am not to much familiar with Akka)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---