Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: mjsax <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-750-flink@git.apache.org>
In-Reply-To: <git-pr-750-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to
 cleanly shut...
Content-Type: text/plain
Message-Id: <20150826152440.1FB9CE046A@git1-us-west.apache.org>
Date: Wed, 26 Aug 2015 15:24:40 +0000 (UTC)

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r37995477
  
    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount/StormWordCountLocal.java ---
    @@ -67,8 +67,10 @@ public static void main(final String[] args) throws Exception {
     
     		Utils.sleep(10 * 1000);
     
    -		// TODO kill does no do anything so far
     		cluster.killTopology(topologyId);
    +		// killing sends STOP signal, takes some time to clean up
    +		Utils.sleep(1000);
    --- End diff --
    
    I want to preserve Storm semantics, which is "send kill signal an hope for the best". So I implemented "Stop" signal the same way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---