Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3EAD51001C for ; Wed, 26 Aug 2015 13:08:35 +0000 (UTC) Received: (qmail 73916 invoked by uid 500); 26 Aug 2015 13:08:35 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 73873 invoked by uid 500); 26 Aug 2015 13:08:35 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 73864 invoked by uid 99); 26 Aug 2015 13:08:34 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 13:08:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8D5FD181BC3 for ; Wed, 26 Aug 2015 13:08:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.975 X-Spam-Level: X-Spam-Status: No, score=0.975 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id t2QyBmpodVog for ; Wed, 26 Aug 2015 13:08:28 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 2D9EF25CFC for ; Wed, 26 Aug 2015 13:08:27 +0000 (UTC) Received: (qmail 73766 invoked by uid 99); 26 Aug 2015 13:08:26 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 13:08:26 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 26FD4E046A; Wed, 26 Aug 2015 13:08:26 +0000 (UTC) From: mjsax To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm... Content-Type: text/plain Message-Id: <20150826130826.26FD4E046A@git1-us-west.apache.org> Date: Wed, 26 Aug 2015 13:08:26 +0000 (UTC) Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-135006223 @ffbin Can you extend `ExclamationTopology` such that the number of added `! `in `ExclamationBolt` and `ExclamationWithStormSpout.ExclamationMap` is configurable and adapt the tests accordingly. Please add an additional user parameter to `ExclamationWithStormSpout` and `ExclamationWithStormBolt`. Furhtermore, please **extend** `FiniteStormFileSpout` or base class with an empty constructor and configure the file to be opened via Storm configuration Map for this case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---