Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16D7417E55 for ; Thu, 20 Aug 2015 10:00:50 +0000 (UTC) Received: (qmail 31487 invoked by uid 500); 20 Aug 2015 10:00:50 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 31449 invoked by uid 500); 20 Aug 2015 10:00:50 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 31440 invoked by uid 99); 20 Aug 2015 10:00:49 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2015 10:00:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 92B3BC0332 for ; Thu, 20 Aug 2015 10:00:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.975 X-Spam-Level: X-Spam-Status: No, score=0.975 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id oohJX4TJphhE for ; Thu, 20 Aug 2015 10:00:42 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 5D4EB42B14 for ; Thu, 20 Aug 2015 10:00:42 +0000 (UTC) Received: (qmail 31176 invoked by uid 99); 20 Aug 2015 10:00:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2015 10:00:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8C138E7151; Thu, 20 Aug 2015 10:00:41 +0000 (UTC) From: tillrohrmann To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-2077] [core] Rework Path class and add ... Content-Type: text/plain Message-Id: <20150820100041.8C138E7151@git1-us-west.apache.org> Date: Thu, 20 Aug 2015 10:00:41 +0000 (UTC) Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1035#issuecomment-132962489 @gallenvara, could you elaborate a little bit on why you've moved the `makeQualified` method into the static `FileSystemUtil` class? What's the benefit of it. Is this the only thing which can be refactored to make the `Path` class more readable? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---