flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2567) CsvParser: Quotes cannot be escaped inside quoted fields
Date Thu, 27 Aug 2015 09:23:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716345#comment-14716345
] 

ASF GitHub Bot commented on FLINK-2567:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1059#discussion_r38076964
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
    @@ -445,7 +445,12 @@ protected int skipFields(byte[] bytes, int startPos, int limit, byte[]
delim) {
     			// quoted string parsing enabled and field is quoted
     			// search for ending quote character
     			i++;
    -			while(i < limit && bytes[i] != quoteCharacter) {
    +
    --- End diff --
    
    Would this be the same as `while (i < limit && (bytes[i] != quoteCharacter
|| bytes[i-1] == 92))`?


> CsvParser: Quotes cannot be escaped inside quoted fields
> --------------------------------------------------------
>
>                 Key: FLINK-2567
>                 URL: https://issues.apache.org/jira/browse/FLINK-2567
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.9, 0.10
>            Reporter: Maximilian Michels
>            Assignee: Tamara
>            Priority: Minor
>             Fix For: 0.10
>
>
> We should allow users to escape the quote character inside a quoted field.
> Quoting could be realized through the \ character like in: {{"This is an \"escaped\"
quotation."}}
> Mailing list thread: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/jira-Created-FLINK-2567-CsvParser-Quotes-cannot-be-escaped-inside-quoted-fields-td7654.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message