flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2556) Fix/Refactor pre-flight Key validation
Date Thu, 27 Aug 2015 18:04:48 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717190#comment-14717190
] 

ASF GitHub Bot commented on FLINK-2556:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1044#issuecomment-135508810
  
    Merging this...


> Fix/Refactor pre-flight Key validation
> --------------------------------------
>
>                 Key: FLINK-2556
>                 URL: https://issues.apache.org/jira/browse/FLINK-2556
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> The pre-flight key validation checks are inconsistent, at times don't actually check
anything and in at least 1 case are done redundantly.
> For example,
> * you can group on a tuple containing a non-Atomic-/CompositeType using String[] KeyExpressions
(see FLINK-2541)
> * you can group on an AtomicType even though isKeyType() returns false, if it is contained
in a tuple
> * for distinct(String[]...) the above fails in the DistinctOperator constructor, as it
validates the key again for some reason.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message