flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2553) Example Jars not build correctly
Date Fri, 21 Aug 2015 14:41:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706805#comment-14706805

ASF GitHub Bot commented on FLINK-2553:

Github user mjsax commented on a diff in the pull request:

    --- Diff: docs/apis/storm_compatibility.md ---
    @@ -224,4 +224,12 @@ DataStream<String> rawInput = env.addSource(
     You can find more examples in Maven module `flink-storm-compatibilty-examples`.
     For the different versions of WordCount, see [README.md](https://github.com/apache/flink/tree/master/flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/README.md).
    +To run the examples, you need to assemble a correct jar file.
    +`flink-storm-compatibility-examples-0.10-SNAPSHOT.jar` is **no** valid jar file for job
execution (it is only a standard maven artifact).
    +There are example jars for embedded Spout and Bolt, namely `flink-storm-compatibility-examples-0.10-SNAPSHOT-WordCountSpoutSource.jar`
and `flink-storm-compatibility-examples-0.10-SNAPSHOT-WordCountBoltTokenizer.jar`, respectively.
    +Compare `pom.xml` to see how both jars are built.
    +Furthermore, there is one example for whole Storm topologies (`flink-storm-compatibility-examples-0.10-SNAPSHOT-WordCountStorm.jar`).
    +This jar is build using `maven-assembly-plugin` because it must contain `defaults.yaml`
which cannot be included using `maven-jar-plugin`.
    --- End diff --
    This does not work as I want it. The shade plugin overwrites some previously build jars
and also installs the example jars to local maven repository. Both is not intended and I was
not able to deactivate it... (`<shadedArtifactAttached>true</shadedArtifactAttached>`
only keeps a copy of the overwritten jar (with different name).

> Example Jars not build correctly
> --------------------------------
>                 Key: FLINK-2553
>                 URL: https://issues.apache.org/jira/browse/FLINK-2553
>             Project: Flink
>          Issue Type: Bug
>          Components: flink-contrib
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
> Due to new examples that introduced some package restructuring, example jar files are
not build correctly. Furthermore, package/class structure got messed up to some extend. Additionally,
documentation need to be extended to point out the correct example jar files.

This message was sent by Atlassian JIRA

View raw message