flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2530) optimize equal() of AcknowledgeCheckpoint
Date Sun, 16 Aug 2015 16:17:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698740#comment-14698740
] 

ASF GitHub Bot commented on FLINK-2530:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1024#issuecomment-131577837
  
    Is this really in need of optimization? It is written failsafe, where it does not crash
even if `state` does not handle null values properly. This is good, because it helps prevent
future bugs. The performance cost is minimal.
    
    Concerning performance:  This is an actor message send and processed asynchronously by
the JobManager. These code paths should never saturate the CPU in any reasonable setup, and
even the computation during the processing of this message is dominated by other parts (cache
misses during hash table lookups). Checking more, this method is never even executed. It is
there only for the sake of testing / debugability.
    
    Please double check whether statements really need fixing. Eliminating checks for the
sake of performance is really only necessary on the most performance critical code paths (the
inner loops of the runtime operators and algorithms).


> optimize equal() of AcknowledgeCheckpoint
> -----------------------------------------
>
>                 Key: FLINK-2530
>                 URL: https://issues.apache.org/jira/browse/FLINK-2530
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>    Affects Versions: 0.8.1
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message