flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2529) fix on some unused code for flink-runtime
Date Tue, 18 Aug 2015 13:30:46 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701246#comment-14701246
] 

ASF GitHub Bot commented on FLINK-2529:
---------------------------------------

Github user HuangWHWHW commented on the pull request:

    https://github.com/apache/flink/pull/1022#issuecomment-132205784
  
    Ha...
    Sorry for my English, just misunderstood the "execution".
    I will learn more about the Thread class.


> fix on some unused code for flink-runtime
> -----------------------------------------
>
>                 Key: FLINK-2529
>                 URL: https://issues.apache.org/jira/browse/FLINK-2529
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 0.10
>            Reporter: Huang Wei
>            Priority: Minor
>             Fix For: 0.10
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> In file BlobServer.java, I found the Thread.currentThread() will never return null in
my learned knowledge.
> So I think "shutdownHook != null“ is not necessary in code 'if (shutdownHook != null
&& shutdownHook != Thread.currentThread())';
> And I am not complete sure.
> Maybe I am wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message