flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility
Date Mon, 31 Aug 2015 13:47:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723414#comment-14723414
] 

ASF GitHub Bot commented on FLINK-2525:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1046#discussion_r38312802
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -275,7 +275,14 @@
     	 * Path to Hadoop configuration
     	 */
     	public static final String PATH_HADOOP_CONFIG = "fs.hdfs.hadoopconf";
    -	
    +
    +	// ------------------------ Storm Configuration ------------------------
    +
    +	/**
    +	 * storm configuration
    +	 */
    +	public static final String STORM_DEFAULT_CONFIG = "storm.config";
    --- End diff --
    
    I think we should put this somewhere else... Maybe adding a new class in `stormcompatibility.util`
package. @StephanEwen what is your opinion?


> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and `Bolt.prepare()`,
respectively. Both methods have a config `Map` as first parameter. This map is currently not
populated. Thus, Spouts and Bolts cannot be configure with user defined parameters. In order
to support this feature, spout and bolt wrapper classes need to be extended to create a proper
`Map` object. Furthermore, the clients need to be extended to take a `Map`, translate it into
a Flink `Configuration` that is forwarded to the wrappers for proper initialization of the
map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message