flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility
Date Mon, 31 Aug 2015 13:40:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723404#comment-14723404
] 

ASF GitHub Bot commented on FLINK-2525:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1046#discussion_r38312112
  
    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWithStormBolt.java
---
    @@ -86,11 +99,40 @@ public static void main(final String[] args) throws Exception {
     	// USER FUNCTIONS
     	// *************************************************************************
     
    -	private static class ExclamationMap implements MapFunction<String, String> {
    +	private static class ExclamationMap extends AbstractRichFunction implements MapFunction<String,
String> {
    +
    +		private String exclamation;
    +
    +		@Override
    +		public void open(Configuration parameters) throws Exception {
    +			exclamation = new String("!!!");
    --- End diff --
    
    move this to new `else` in line 121 to make clear it is the default value in case no config
is given.


> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and `Bolt.prepare()`,
respectively. Both methods have a config `Map` as first parameter. This map is currently not
populated. Thus, Spouts and Bolts cannot be configure with user defined parameters. In order
to support this feature, spout and bolt wrapper classes need to be extended to create a proper
`Map` object. Furthermore, the clients need to be extended to take a `Map`, translate it into
a Flink `Configuration` that is forwarded to the wrappers for proper initialization of the
map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message