flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility
Date Mon, 24 Aug 2015 12:44:48 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709194#comment-14709194

ASF GitHub Bot commented on FLINK-2525:

Github user mjsax commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
    @@ -41,8 +43,49 @@ public void submitTopology(final String topologyName, final Map<?,
?> conf, fina
     	public void submitTopologyWithOpts(final String topologyName, final Map<?, ?>
conf, final FlinkTopology topology,
     			final SubmitOptions submitOpts) throws Exception {
    -		ClusterUtil
    -				.startOnMiniCluster(topology.getStreamGraph().getJobGraph(topologyName), topology.getNumberOfTasks());
    +		JobGraph jobGraph = topology.getStreamGraph().getJobGraph(topologyName);
    +		Configuration jobConfiguration = jobGraph.getJobConfiguration();
    +		/* storm conf type must be Map<String, Object> */
    +		Map<String, Object> stormConf = (Map<String, Object>)conf;
    --- End diff --
    The definition of `Config` in not important here. Storm uses raw map as parameter in `StormSubmitter.submitTopology(...)`,
`Spout.open(...)`, and `Bolt.prepare(...)`. Thus, it would be possible to use a different
type than `String` for key values.

> Add configuration support in Storm-compatibility
> ------------------------------------------------
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: flink-contrib
>            Reporter: fangfengbin
>            Assignee: fangfengbin
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and `Bolt.prepare()`,
respectively. Both methods have a config `Map` as first parameter. This map is currently not
populated. Thus, Spouts and Bolts cannot be configure with user defined parameters. In order
to support this feature, spout and bolt wrapper classes need to be extended to create a proper
`Map` object. Furthermore, the clients need to be extended to take a `Map`, translate it into
a Flink `Configuration` that is forwarded to the wrappers for proper initialization of the

This message was sent by Atlassian JIRA

View raw message