flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2457) Integrate Tuple0
Date Thu, 06 Aug 2015 12:36:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659941#comment-14659941
] 

ASF GitHub Bot commented on FLINK-2457:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/983#discussion_r36408488
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/Tuple0Serializer.java
---
    @@ -0,0 +1,86 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
agreements. See the NOTICE
    + * file distributed with this work for additional information regarding copyright ownership.
The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the "License"); you may not use this
file except in compliance with the
    + * License. You may obtain a copy of the License at
    + * 
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on
    + * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied. See the License for the
    + * specific language governing permissions and limitations under the License.
    + */
    +package org.apache.flink.api.java.typeutils.runtime;
    +
    +import java.io.IOException;
    +
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.api.java.tuple.Tuple0;
    +import org.apache.flink.core.memory.DataInputView;
    +import org.apache.flink.core.memory.DataOutputView;
    +
    +public class Tuple0Serializer extends TupleSerializer<Tuple0> {
    +	private static final long serialVersionUID = 1278813169022975971L;
    +
    +	public Tuple0Serializer() {
    +		super(Tuple0.class, new TypeSerializer<?>[0]);
    +	}
    +
    +	@Override
    +	public Tuple0Serializer duplicate() {
    +		return new Tuple0Serializer();
    --- End diff --
    
    No need to create a new instance, since this is stateless.


> Integrate Tuple0
> ----------------
>
>                 Key: FLINK-2457
>                 URL: https://issues.apache.org/jira/browse/FLINK-2457
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Tuple0 is not cleanly integrated:
>   - missing serialization/deserialization support in runtime
>  - Tuple.getTupleClass(int arity) cannot handle arity zero, ie, cannot create an instance
of Tuple0
> Tuple0 is currently only used in Python API, but will be integrated into Storm compatibility,
too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message