flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2457) Integrate Tuple0
Date Thu, 06 Aug 2015 12:34:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659935#comment-14659935
] 

ASF GitHub Bot commented on FLINK-2457:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/983#discussion_r36408352
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple0Builder.java
---
    @@ -0,0 +1,46 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +
    +// --------------------------------------------------------------
    +//  THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
    +//  GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
    +// --------------------------------------------------------------
    +
    +
    +package org.apache.flink.api.java.tuple.builder;
    +
    +import java.util.LinkedList;
    +import java.util.List;
    +
    +import org.apache.flink.api.java.tuple.Tuple0;
    +
    +public class Tuple0Builder {
    +
    +	private List<Tuple0> tuples = new LinkedList<Tuple0>();
    --- End diff --
    
    ArrayLists are almost always way superior in performance than LinkedLists.


> Integrate Tuple0
> ----------------
>
>                 Key: FLINK-2457
>                 URL: https://issues.apache.org/jira/browse/FLINK-2457
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Tuple0 is not cleanly integrated:
>   - missing serialization/deserialization support in runtime
>  - Tuple.getTupleClass(int arity) cannot handle arity zero, ie, cannot create an instance
of Tuple0
> Tuple0 is currently only used in Python API, but will be integrated into Storm compatibility,
too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message