flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2451) Cleanup Gelly examples
Date Thu, 13 Aug 2015 11:32:51 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695067#comment-14695067
] 

ASF GitHub Bot commented on FLINK-2451:
---------------------------------------

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1000#discussion_r36963490
  
    --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/GatherSumApplyITCase.java
---
    @@ -86,26 +72,35 @@ public void testConnectedComponents() throws Exception {
     
     	@Test
     	public void testSingleSourceShortestPaths() throws Exception {
    -		GSASingleSourceShortestPaths.main(new String[]{"1", edgesPath, resultPath, "16"});
    -		expectedResult = "1 0.0\n" +
    -				"2 12.0\n" +
    -				"3 13.0\n" +
    -				"4 47.0\n" +
    -				"5 48.0\n" +
    -				"6 Infinity\n" +
    -				"7 Infinity\n";
    +		final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
    +
    +		Graph<Long, Double, Double> inputGraph = Graph.fromDataSet(
    +				SingleSourceShortestPathsData.getDefaultEdgeDataSet(env),
    +				new InitMapperSSSP(), env);
    +
    +        List<Vertex<Long, Double>> result = inputGraph.run(new GSASingleSourceShortestPaths<Long>(1l,
16))
    +        		.getVertices().collect();
    --- End diff --
    
    Yes, we do! The idea is to lazily mitigate the rest of the tests, too. Take a look at
FLINK-2032.


> Cleanup Gelly examples
> ----------------------
>
>                 Key: FLINK-2451
>                 URL: https://issues.apache.org/jira/browse/FLINK-2451
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 0.10
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>            Priority: Minor
>
> As per discussion in the dev@ mailing list, this issue proposes the following changes
to the Gelly examples and library:
> 1. Keep the following examples as they are:
> EuclideanGraphWeighing, GraphMetrics, IncrementalSSSP, JaccardSimilarity,  MusicProfiles.
> 2. Keep only 1 example to show how to use library methods.
> 3. Add 1 example for vertex-centric iterations.
> 4. Keep 1 example for GSA iterations and move the redundant GSA implementations to the
library.
> 5. Improve the examples documentation and refer to the functionality that each of them
demonstrates.
> 6. Port and modify existing example tests accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message